Skip to content

Conversation

djkoloski
Copy link
Contributor

This also adds file locking around calls to pm publish as these calls are not thread-safe.

@djkoloski
Copy link
Contributor Author

r? @tmandry

@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 28, 2023
@rustbot rustbot assigned tmandry and unassigned Mark-Simulacrum Feb 28, 2023
@tmandry
Copy link
Member

tmandry commented Mar 1, 2023

Exciting!

r=me after comment

@bors delegate+ rollup

@bors
Copy link
Collaborator

bors commented Mar 1, 2023

✌️ @djkoloski can now approve this pull request

@djkoloski djkoloski force-pushed the parallel_fuchsia_test_runner branch from e8121b6 to c9f1a54 Compare March 1, 2023 20:35
@djkoloski
Copy link
Contributor Author

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 1, 2023

📌 Commit c9f1a54 has been approved by djkoloski

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2023
@tmandry
Copy link
Member

tmandry commented Mar 2, 2023

Use

@bors r=tmandry

instead of r+

@bors
Copy link
Collaborator

bors commented Mar 2, 2023

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 2, 2023

📌 Commit c9f1a54 has been approved by tmandry

It is now in the queue for this repository.

@djkoloski
Copy link
Contributor Author

😓 I didn't read

@tmandry
Copy link
Member

tmandry commented Mar 2, 2023

All good, it just looks a little sus on the bors dashboard

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#108516 (Restrict `#[rustc_box]` to `Box::new` calls)
 - rust-lang#108575 (Erase **all** regions when probing for associated types on ambiguity in astconv)
 - rust-lang#108585 (Run compiler test suite in parallel on Fuchsia)
 - rust-lang#108606 (Add test case for mismatched open/close delims)
 - rust-lang#108609 (Highlight whole expression for E0599)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 478d530 into rust-lang:master Mar 2, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 2, 2023
@tmandry tmandry added the O-fuchsia Operating system: Fuchsia label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants